Page MenuHomePhabricator

build: remove eina-bench-cmp from DIST list
ClosedPublic

Authored by akanad on Jan 29 2019, 2:40 PM.

Details

Summary

the script has been removed on meson.build cause it's quite useless.
this patch removes it from autotools build also.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9242
Build 7883: arc lint + arc unit
akanad created this revision.Jan 29 2019, 2:40 PM
akanad requested review of this revision.Jan 29 2019, 2:40 PM

Wouldn't it be better to make python an optional dependencies and only enable that script in that case?

Wouldn't it be better to make python an optional dependencies and only enable that script in that case?

files on DIST list will be packaged and which means some systems that the Eina package has installed on, have python dependency.
IMO, the main point here is that the script is useful or not.

I do not exactly know what eina-bench-cmp is, and how useful it is.
I just assumed that it's not that useful because it was described on meson that has adopted later than automake build system.

please let me know your opinion.
thanks.

bu5hm4n accepted this revision.Jan 30 2019, 12:07 AM

@cedric That does not make sense here, since this script has no purpose, it cannot parse anything that gets outputted by something in the efl tree, the comments in the script it self are speaking about exactness. However, this output does also appear to be different than the script. Its questionable why this script is even in the tree to me ... :/

This revision is now accepted and ready to land.Jan 30 2019, 12:07 AM
Closed by commit rEFL50c22e980b47: build: remove eina-bench-cmp from DIST list (authored by WhiskyKiloSq, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyJan 30 2019, 4:32 AM
This revision was automatically updated to reflect the committed changes.