Page MenuHomePhabricator

replace hton and ntoh family functions with ones defined in eina
ClosedPublic

Authored by vtorri on Jan 30 2019, 12:23 PM.

Details

Summary

This fixes especially the execution of edje_cc on Windows

Test Plan

execution of edje_cc

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vtorri created this revision.Jan 30 2019, 12:23 PM
vtorri requested review of this revision.Jan 30 2019, 12:23 PM
vtorri added a comment.EditedJan 30 2019, 10:12 PM

somme comments:

  • configure.ac and eina_config.h.in : to set EINA_HAVE_BIGENDIAN at configure time
  • eina_inline_cpu.x and eina_cpu.h : code and déclaration of the new functions
  • the other files are just renaming hton* and ntoh* function with eina_ prefix
  • header files needed by hton and ntoh functions are removed
raster accepted this revision.Feb 1 2019, 6:26 AM

i had to make fixes as you removed some include blocks that are needed still for other inet funcs and missed adding linking/headers to other code.

This revision is now accepted and ready to land.Feb 1 2019, 6:26 AM
This revision was automatically updated to reflect the committed changes.

Just out of curiosity, did you try compiling after you made changes and before landing?

@ManMower if the question is for me, yes : Windows and Fedora

@vtorri, not for you, @raster commented that he changed the patch when landing.