Page MenuHomePhabricator

efl_ui_tab_bar: fix tab sizing issue
ClosedPublic

Authored by bowonryu on Jan 30 2019, 9:55 PM.

Details

Summary

The default value of hint_align has changed.
So change the hint_align of tab(layout) to HINT_FILL.

  • Recently, the size_hint_fill API has been added, but currently tab_bar is not available because it uses evas_object_box.
  • I plan to change evas_object_box to efl.ui.box in the future.
Test Plan

elementary_test -to efl.ui.tab_pager

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bowonryu created this revision.Jan 30 2019, 9:55 PM
bowonryu requested review of this revision.Jan 30 2019, 9:55 PM

as I understand, this patch is required because tab is packed to elm_box.
if so, could you add FIXME comment on here?

src/lib/elementary/efl_ui_tab_bar.c
225

could you add FIXME comment on here to let people know why hint_align is used with EVAS_HINT_FILL?

bowonryu updated this revision to Diff 19096.Jan 31 2019, 1:44 AM

add FIXME

Jaehyun_Cho accepted this revision.Jan 31 2019, 1:56 AM

Thank you :)

This revision is now accepted and ready to land.Jan 31 2019, 1:56 AM
This revision was automatically updated to reflect the committed changes.