Page MenuHomePhabricator

eo: fix efl_isa to work propertly with interfaces
ClosedPublic

Authored by bu5hm4n on Fri, Feb 1, 2:11 AM.

Details

Summary

mro only contains special interfaces, not in general all, in order to
have a working function, while NOT having a bad performance. In order to
achive that we just copy the code that is done on efl_isa for a object.
which is a linear walk of a list

ref D7857

Depends on D7776

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Fri, Feb 1, 2:11 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

bu5hm4n requested review of this revision.Fri, Feb 1, 2:11 AM
bu5hm4n updated this revision to Diff 19143.Fri, Feb 1, 2:17 AM
bu5hm4n edited the summary of this revision. (Show Details)

fix

SanghyeonLee accepted this revision.Fri, Feb 1, 2:31 AM
SanghyeonLee added a subscriber: SanghyeonLee.

It works very well. thank you so much :)

This revision is now accepted and ready to land.Fri, Feb 1, 2:31 AM
Closed by commit rEFL32a2268f46f8: eo: fix efl_isa to work propertly with interfaces (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyFri, Feb 1, 2:32 AM
This revision was automatically updated to reflect the committed changes.

I'd never think that the class vtable contains the object's vtable. I thought the klass vtable would contain only the vtable for Efl_Class and Efl_Object methods.

I think this is the complete vtable, isn't that the vtable where we are just passing on the pointer to the object ?