This make sure that the object returned by children_slice_get are properly
destroyed when the refcount drop to only the parent holding a reference on
it. This make it clear that the user of the api can rely on efl_ref/efl_unref
to actually manage its use of the returned object.
Details
Details
Diff Detail
Diff Detail
- Repository
- rEFL core/efl
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Can you please check all this alleged leaks and tell me if they are right or wrong?
Also, is this patch trying to fix an actual problem? Is there some crash that this fixes? It should be explained in the commit message.
| src/lib/ecore/efl_select_model.c | ||
|---|---|---|
| 162 | Shouldn't this path unref obj too? | |
| 180 | Shouldn't this path unref obj too? | |
| 343 | Shouldn't this also add a .free function to unref the parent? | |
| 355–357 | Shouldn't this also add a .free function to unref obj? | |