Page MenuHomePhabricator

Revert "autotools: evil: add needed -lmsvcr100 library flag for _create/_free_locale()"
AbandonedPublic

Authored by stefan_schmidt on Mon, Feb 4, 6:30 AM.

Details

Reviewers
vtorri
Summary

This reverts commit 4aeb3e20c95c53b9a856a9269d691cbc275839a4.

We used this linking as a bandaid to compile after the addition of named
functions. As it turns out that helped to compile the code but it still
has trouble during runtime and also brings in other problems.

To help all this Vicent added the needed functionality directly to eina
in commit f7c560c311d0ba0da94346e17c8b20f40a0ed152 and we no longer need
this.

Diff Detail

Repository
rEFL core/efl
Branch
ci-experiments
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 9339
stefan_schmidt created this revision.Mon, Feb 4, 6:30 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

vtorri added a subscriber: raster.Mon, Feb 4, 6:45 AM

we need a strtod implementation. I have one that i have sent to @raster by mail.
this strtod function can be used for all platform

btw, it seems that eina_convert_strtod_c() is never used in the git (according to @raster)

ok, good to know. I thought it fully solved as the cross build works again with this revert.

Let's keep this patch here so we can use it when the strtod_c patch lands.

can be abandoned after push of D7926 (D7926 also fixes meson)

stefan_schmidt abandoned this revision.Wed, Feb 13, 7:40 AM