Page MenuHomePhabricator

efl_ui_layout: check part existence in text_set
Needs RevisionPublic

Authored by zmike on Wed, Feb 6, 12:57 PM.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 9385
zmike created this revision.Wed, Feb 6, 12:57 PM
zmike requested review of this revision.Wed, Feb 6, 12:57 PM

Hum, I have been reading this patch, and I think the correct patch might be requiring more work. I think efl_text_set should be able to return an error code if a part doesn't exist or if it fails. We can make setter return an Eina.Error, make the implementation in src/lib/edje/edje_part_invalid.c return an error code and directly return that here. This would make the API more future proof I think.

cedric requested changes to this revision.Mon, Feb 11, 2:41 PM
This revision now requires changes to proceed.Mon, Feb 11, 2:41 PM