Page MenuHomePhabricator

efl_gfx_color_class: make this a mixin and move color_class_code here
ClosedPublic

Authored by zmike on Feb 8 2019, 10:50 AM.

Details

Summary

color_class_code seems to only have been added to efl_gfx_color in order to
share the hex conversion code, but this is trivial to do when it's in another
class and makes the api more sensible

ref T7559

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Feb 8 2019, 10:50 AM
zmike requested review of this revision.Feb 8 2019, 10:50 AM
segfaultxavi accepted this revision.Feb 11 2019, 3:33 AM

So now Efl.Gfx.Color is a mixin with a pure virtual color property which implements color<->code conversion for convenience.
Efl.Gfx.Color_Class behaves exactly the same way but for color classes (so you can set the color to specific "layers" of a widget, like the Outline or the Shadow).

Makes sense to me. Also, it builds and passes tests. Landing.

This revision is now accepted and ready to land.Feb 11 2019, 3:33 AM
This revision was automatically updated to reflect the committed changes.