Page MenuHomePhabricator

efl_input: remove the API of efl_input_instance_get
ClosedPublic

Authored by bu5hm4n on Sat, Feb 9, 12:45 PM.

Details

Summary

there is basically no reason for this API. You can only use the API when
you know the class, when you know the class you can also just know the
function to call to get this API.
The reason this API needs to go is that we don't want to use
polymorphism on class-functions.

ref T7675

Depends on D7924

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Sat, Feb 9, 12:45 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

bu5hm4n requested review of this revision.Sat, Feb 9, 12:45 PM
bu5hm4n updated this revision to Diff 19360.Wed, Feb 13, 7:35 AM
bu5hm4n edited the summary of this revision. (Show Details)

remove dead func

segfaultxavi accepted this revision.Wed, Feb 13, 7:44 AM

Cannot see anything obviously broken.

src/lib/evas/canvas/efl_input_hold.c
89

Double ;; while you are here :)

This revision is now accepted and ready to land.Wed, Feb 13, 7:44 AM
Closed by commit rEFL3b2a5a429be1: efl_input: remove the API of efl_input_instance_get (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyWed, Feb 13, 8:00 AM
This revision was automatically updated to reflect the committed changes.