Details

Reviewers

cedric
segfaultxavi
zmike

Maniphest Tasks

T7675: Do not allow static-function polymorphism

Commits

rEFL3b2a5a429be1: efl_input: remove the API of efl_input_instance_get

Summary

there is basically no reason for this API. You can only use the API when
you know the class, when you know the class you can also just know the
function to call to get this API.
The reason this API needs to go is that we don't want to use
polymorphism on class-functions.

ref T7675

Depends on D7924

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

bu5hm4n created this revision.Feb 9 2019, 12:45 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

bu5hm4n requested review of this revision.Feb 9 2019, 12:45 PM

bu5hm4n added a child revision: D7901: eolian: drop class function overriding.

Harbormaster completed remote builds in B9413: Diff 19266.Feb 9 2019, 12:45 PM

bu5hm4n mentioned this in D7901: eolian: drop class function overriding.Feb 10 2019, 12:06 AM

bu5hm4n added reviewers: cedric, segfaultxavi, zmike.Feb 10 2019, 12:29 PM

update

Harbormaster completed remote builds in B9449: Diff 19318.Feb 12 2019, 3:18 AM

update

Harbormaster completed remote builds in B9454: Diff 19324.Feb 12 2019, 4:06 AM

remove dead func

Harbormaster completed remote builds in B9483: Diff 19360.Feb 13 2019, 7:35 AM

Cannot see anything obviously broken.

src/lib/evas/canvas/efl_input_hold.c
89	Double ;; while you are here :)

This revision is now accepted and ready to land.Feb 13 2019, 7:44 AM

bu5hm4n removed a parent revision: D7924: Remove individual class BETA guards.Feb 13 2019, 7:46 AM

Closed by commit rEFL3b2a5a429be1: efl_input: remove the API of efl_input_instance_get (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyFeb 13 2019, 8:00 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/lib/ecore_evas/ecore_evas.c (14 lines)
M			src/lib/elementary/efl_ui_win.c (2 lines)
M			src/lib/evas/Evas_Internal.h (6 lines)
M			src/lib/evas/canvas/efl_input_event.c (2 lines)
M			src/lib/evas/canvas/efl_input_focus.c (11 lines)
M			src/lib/evas/canvas/efl_input_hold.c (11 lines)
M			src/lib/evas/canvas/efl_input_key.c (12 lines)
M			src/lib/evas/canvas/efl_input_pointer.c (12 lines)
M			src/lib/evas/canvas/evas_events.c (20 lines)
M			src/lib/evas/canvas/evas_focus.c (2 lines)
M			src/lib/evas/canvas/evas_main.c (2 lines)
M			src/lib/evas/include/evas_private.h (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	19266	b805f11		Feb 9 2019, 12:45 PM	★	★
Diff 2	19318	fac3fa1	update	Feb 12 2019, 3:18 AM	★	★
Diff 3	19324	fac3fa1	update	Feb 12 2019, 4:06 AM	★	★
Diff 4	19360	227e49a	remove dead func	Feb 13 2019, 7:34 AM	★	★
Diff 5	19364	33c4041	rEFL3b2a5a429be16e5b8e5d322b7a077a2c849586b8	Feb 13 2019, 7:59 AM	★	★

efl_input: remove the API of efl_input_instance_get
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 19364

src/lib/ecore_evas/ecore_evas.c

src/lib/elementary/efl_ui_win.c

src/lib/evas/Evas_Internal.h

src/lib/evas/canvas/efl_input_event.c

src/lib/evas/canvas/efl_input_focus.c

src/lib/evas/canvas/efl_input_hold.c

src/lib/evas/canvas/efl_input_key.c

src/lib/evas/canvas/efl_input_pointer.c

src/lib/evas/canvas/evas_events.c

src/lib/evas/canvas/evas_focus.c

src/lib/evas/canvas/evas_main.c

src/lib/evas/include/evas_private.h

efl_input: remove the API of efl_input_instance_getClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 19364

src/lib/ecore_evas/ecore_evas.c

src/lib/elementary/efl_ui_win.c

src/lib/evas/Evas_Internal.h

src/lib/evas/canvas/efl_input_event.c

src/lib/evas/canvas/efl_input_focus.c

src/lib/evas/canvas/efl_input_hold.c

src/lib/evas/canvas/efl_input_key.c

src/lib/evas/canvas/efl_input_pointer.c

src/lib/evas/canvas/evas_events.c

src/lib/evas/canvas/evas_focus.c

src/lib/evas/canvas/evas_main.c

src/lib/evas/include/evas_private.h

efl_input: remove the API of efl_input_instance_get
ClosedPublic
Actions

Revision Contents
Changeset List