Page MenuHomePhabricator

eo: efl_isa with a EFL_OVERRIDE_CLASS should return true
ClosedPublic

Authored by bu5hm4n on Mon, Feb 11, 10:23 AM.

Details

Summary

this is important, as basically every single class etc. can be a
EFL_OVERRIDE_CLASS. This makes efl_override work with eo_debug.

Depends on D7909

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Mon, Feb 11, 10:23 AM
bu5hm4n requested review of this revision.Mon, Feb 11, 10:23 AM

Can you add some documentation in the C file itself to explain why there is this line? Because otherwise it look a little bit adhoc.

cedric requested changes to this revision.Mon, Feb 11, 10:35 AM
This revision now requires changes to proceed.Mon, Feb 11, 10:35 AM
bu5hm4n updated this revision to Diff 19298.Mon, Feb 11, 10:40 AM
bu5hm4n edited the summary of this revision. (Show Details)

doc++

cedric accepted this revision.Mon, Feb 11, 10:40 AM
This revision is now accepted and ready to land.Mon, Feb 11, 10:40 AM
Closed by commit rEFL87373bf66ccb: eo: efl_isa with a EFL_OVERRIDE_CLASS should return true (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyTue, Feb 12, 2:26 AM
This revision was automatically updated to reflect the committed changes.