Page MenuHomePhabricator

ecore_main: Add ECORE_FD_ALWAYS flag
ClosedPublic

Authored by ManMower on Feb 12 2019, 8:40 AM.

Details

Summary

This allows an fd handler to be called after select exits unconditionally.

Our wayland client code needs this to be thread safe, as it needs to
call prepare_read before entering select, and then either read or
cancel_read after select.

Diff Detail

Repository
rEFL core/efl
Branch
fix_wayland_threading
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 9488
ManMower created this revision.Feb 12 2019, 8:40 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

cedric requested changes to this revision.Feb 12 2019, 8:54 AM

Interesting idea, just a small nitpick.

src/lib/ecore/ecore_main.c
1920–1921

Why is that left here? Seems confusing.

This revision now requires changes to proceed.Feb 12 2019, 8:54 AM
zmike added a subscriber: zmike.Feb 12 2019, 9:12 AM
zmike added inline comments.
src/lib/ecore/Ecore_Common.h
1392

Maybe add some small fragment of documentation which explains what this means?

ManMower updated this revision to Diff 19331.Feb 12 2019, 9:53 AM

slightly better "documentation"

fix dangling return

cedric accepted this revision.Feb 12 2019, 9:55 AM
This revision is now accepted and ready to land.Feb 12 2019, 9:55 AM
ManMower updated this revision to Diff 19332.Feb 12 2019, 10:12 AM

stronger comments

This revision was automatically updated to reflect the committed changes.
devilhorns reopened this revision.Feb 13 2019, 7:22 AM
This revision is now accepted and ready to land.Feb 13 2019, 7:22 AM
ManMower updated this revision to Diff 19363.Feb 13 2019, 7:45 AM

Make sure clean up is called after all the adds

ManMower updated this revision to Diff 19368.Feb 13 2019, 8:17 AM

return true if we added a callback from an always handler

devilhorns accepted this revision.Feb 13 2019, 8:25 AM
devilhorns closed this revision.Feb 13 2019, 8:25 AM