Page MenuHomePhabricator

ecore_wl2: Make our wayland socket handling thread safe
ClosedPublic

Authored by ManMower on Feb 12 2019, 8:41 AM.

Details

Summary

By using the prepare read code properly we can do wayland dispatch of
multiple queues in multiple threads. I'm not advocating we ever do so,
but if a library (perhaps a gl implementation) wants to dispatch its own
queue, and that happens in a separate thread from our event loop, we
probably don't want the world to explode.
Depends on D7914

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ManMower created this revision.Feb 12 2019, 8:41 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ManMower requested review of this revision.Feb 12 2019, 8:41 AM

This looks good to me :) Cannot test yet tho (waiting on D7914)

This patch, together with D7914 is just causing complete lockups :( Tested 3 times with Enlightenment, and 3 times with EFL apps inside Weston. All tests resulted in complete lockups of EFL apps :(

This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2019, 6:58 AM
This revision was automatically updated to reflect the committed changes.
devilhorns reopened this revision.Feb 13 2019, 7:22 AM
devilhorns accepted this revision.Feb 13 2019, 8:25 AM
This revision is now accepted and ready to land.Feb 13 2019, 8:25 AM
devilhorns closed this revision.Feb 13 2019, 8:25 AM