Page MenuHomePhabricator
Differential D7923

New entry is added to _ecore_key_grabs even when no key was grabbed.
ClosedPublic
Actions

Authored by thierry1970 on Feb 13 2019, 2:44 AM.

Details

Reviewers
zmike
Commits
rEFL56f06d21c19c: ecore-x: only modify _ecore_key_grabs when key is toggled
Summary

The key grab and ungrab functions should return which keycode was used. Proposed by pascal@ordissimo.com

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
thierry1970 created this revision.Feb 13 2019, 2:44 AM
Herald added a project: efl. · View Herald TranscriptFeb 13 2019, 2:44 AM
Herald added subscribers: committers, reviewers, cedric. · View Herald Transcript

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

thierry1970 requested review of this revision.Feb 13 2019, 2:44 AM
zmike added a subscriber: zmike.Feb 13 2019, 5:23 AM

This makes sense. Can you reformat the commit log to be more like

ecore-x: some summary message goes here

some slightly longer description here
zmike requested changes to this revision.Feb 13 2019, 5:23 AM
zmike added a reviewer: zmike.
This revision now requires changes to proceed.Feb 13 2019, 5:23 AM
thierry1970 retitled this revision from New entry is added to _ecore_key_grabs even when no key was grabbed. The key grab and ungrab functions should return which keycode was used. Proposed by pascal@ordissimo.com to New entry is added to _ecore_key_grabs even when no key was grabbed..Feb 13 2019, 8:23 AM
thierry1970 edited the summary of this revision. (Show Details)
zmike accepted this revision.Feb 13 2019, 8:27 AM

Okay, I'll just take care of it. Thx!

This revision is now accepted and ready to land.Feb 13 2019, 8:27 AM
Closed by commit rEFL56f06d21c19c: ecore-x: only modify _ecore_key_grabs when key is toggled (authored by Thierry <thierry@substantiel.fr>, committed by zmike). · Explain WhyFeb 13 2019, 8:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/lib/ecore_x/ecore_x.c (18 lines)

Diff 19369

View Options

src/lib/ecore_x/ecore_x.c

Loading...