Page MenuHomePhabricator

efl_ui : fix infinite loop in efl_ui_exact model
ClosedPublic

Authored by SanghyeonLee on Feb 13 2019, 3:35 AM.

Details

Summary

the loop in infinite because of wrong condition.
need to loop while the count of list_index.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
SanghyeonLee created this revision.Feb 13 2019, 3:35 AM
SanghyeonLee requested review of this revision.Feb 13 2019, 3:35 AM

this bug is detected by our coverity and I think this is right fix.
also there are some warns about memory leak of cbuf, but it looks reallocation of tbuf, so it looks safe on my view, but I hope you double check it.

zmike requested changes to this revision.Feb 13 2019, 5:25 AM
zmike added a subscriber: zmike.

Can you convert this to a for loop to make it a bit more readable? Otherwise seems like a good fix.

This revision now requires changes to proceed.Feb 13 2019, 5:25 AM

rebasing and update while to for statement.

zmike accepted this revision.Feb 14 2019, 5:51 AM

Thanks! I changed the i declaration to be unsigned int to avoid a signedness compiler warning when landing.

This revision is now accepted and ready to land.Feb 14 2019, 5:51 AM
This revision was automatically updated to reflect the committed changes.