Page MenuHomePhabricator

build: add a option to bootstrap eolian
ClosedPublic

Authored by bu5hm4n on Feb 13 2019, 6:46 AM.

Details

Summary

this is here in order to make cross compiling easier, and we can just
provide the *all the time changing* eolian_gen binary.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Feb 13 2019, 6:46 AM

Please respin with a fixed option description.

Also I would like to understand if the changed ifef is really needed or if that should be a separate patch.

As a more general note this is a good start and fixes the problem at hand (changing eolian stuff breaks the cross compile on CI). As a more complete solution we might later need to revisit this and see if we want to have a bootstrap target that builds all of the needed native tools for cross compile (edje_cc, elm_prefs_cc, eet, etc). Still ok to have this patch only for now.

meson_options.txt
360

Either " do not use when not knowing" or "use only if knowing" :-)

src/lib/eo/Eo.h
186 ↗(On Diff #19355)

Why is this needed for the build target?

bu5hm4n planned changes to this revision.Feb 13 2019, 7:56 AM
bu5hm4n marked an inline comment as done.
bu5hm4n added inline comments.
meson_options.txt
360

Will be fixed!

src/lib/eo/Eo.h
186 ↗(On Diff #19355)

Accident :[

bu5hm4n updated this revision to Diff 19367.Feb 13 2019, 8:05 AM
bu5hm4n marked an inline comment as done.

remove unneeded changes

stefan_schmidt accepted this revision.Feb 14 2019, 2:04 AM
This revision is now accepted and ready to land.Feb 14 2019, 2:04 AM
Closed by commit rEFLac6061057355: build: add a option to bootstrap eolian (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by stefan_schmidt). · Explain WhyFeb 14 2019, 4:01 AM
This revision was automatically updated to reflect the committed changes.