Page MenuHomePhabricator

efl.canvas.scene: improve class docs
ClosedPublic

Authored by zmike on Feb 14 2019, 12:24 PM.

Details

Summary

these were some pretty efl docs, and I've tried to make them more accessible

ref T7584

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Feb 14 2019, 12:24 PM
zmike requested review of this revision.Feb 14 2019, 12:24 PM
segfaultxavi requested changes to this revision.Feb 15 2019, 1:16 AM

Much better, thanks. Just those two little unknown e references.

src/lib/efl/interfaces/efl_canvas_scene.eo
96

Any idea what e was meant to be here? It's not a param of this method.

122

Again, what is e?

This revision now requires changes to proceed.Feb 15 2019, 1:16 AM
zmike updated this revision to Diff 19442.Feb 15 2019, 6:07 AM

I don't know what this is so I removed it

segfaultxavi accepted this revision.Feb 15 2019, 7:15 AM

That is usually my approach too :D

This revision is now accepted and ready to land.Feb 15 2019, 7:15 AM
This revision was automatically updated to reflect the committed changes.