Page MenuHomePhabricator

efl.screen: add screen_size_in_mm property
ClosedPublic

Authored by zmike on Feb 15 2019, 11:01 AM.

Details

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Feb 15 2019, 11:01 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Feb 15 2019, 11:01 AM
segfaultxavi requested changes to this revision.Feb 15 2019, 11:41 AM
segfaultxavi added a subscriber: segfaultxavi.
segfaultxavi added inline comments.
src/lib/efl/interfaces/efl_screen.eo
23

How does the user know if this info is available or not?

This revision now requires changes to proceed.Feb 15 2019, 11:41 AM
zmike added inline comments.Feb 15 2019, 11:42 AM
src/lib/efl/interfaces/efl_screen.eo
23

Check the values I guess? Nothing in efl implements this yet.

zmike updated this revision to Diff 19448.Feb 15 2019, 11:57 AM
zmike edited the summary of this revision. (Show Details)
segfaultxavi accepted this revision.Feb 15 2019, 2:39 PM
segfaultxavi added inline comments.
src/lib/efl/interfaces/efl_screen.eo
23

I mean that we should say something like "If this value is not available then the returned value will be [0, 0]" or [-1, -1], or whatever.
And then the implementations will need to stick to it, of course.

This revision is now accepted and ready to land.Feb 15 2019, 2:39 PM
segfaultxavi requested changes to this revision.Feb 21 2019, 7:43 AM
segfaultxavi added inline comments.
src/lib/efl/interfaces/efl_screen.eo
31

This should not be added here :)

This revision now requires changes to proceed.Feb 21 2019, 7:43 AM
zmike added inline comments.Feb 21 2019, 8:51 AM
src/lib/efl/interfaces/efl_screen.eo
31

ffffffff

This revision is now accepted and ready to land.Feb 21 2019, 9:18 AM
This revision was automatically updated to reflect the committed changes.