Page MenuHomePhabricator

efl.screen: add screen_scale_factor property
ClosedPublic

Authored by zmike on Feb 15 2019, 11:01 AM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Feb 15 2019, 11:01 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Feb 15 2019, 11:01 AM
segfaultxavi requested changes to this revision.Feb 15 2019, 11:45 AM
segfaultxavi added a subscriber: segfaultxavi.
segfaultxavi added inline comments.
src/lib/efl/interfaces/efl_screen.eo
26

How does the user know if this information is available or not? Say something like "the return value will be [0,0] if unknown".

Also, scale factors can be extremely confusing. A scale of 2 means that I need to scale my values by two to get the same results, or that EFL will scale my values by two so everything will be twice as large?
An example would be greatly appreciated

This revision now requires changes to proceed.Feb 15 2019, 11:45 AM
zmike planned changes to this revision.Feb 15 2019, 11:50 AM
zmike added inline comments.
src/lib/efl/interfaces/efl_screen.eo
26

Oh actually this should return a double/float, so good catch on the first part.

I think scaling is a case-by-case kind of thing? If you want something to scale then you need to multiply any absolute sizes that you set by the elm_config scale value (no idea what this is in interfaces api).

The value here probably isn't directly used by anything since, based on how efl is trying to be implemented, the user should be setting a global 'scaling' factor which will be entirely arbitrary.

zmike updated this revision to Diff 19449.Feb 15 2019, 11:57 AM
zmike edited the summary of this revision. (Show Details)
segfaultxavi accepted this revision.Feb 21 2019, 2:59 AM
This revision is now accepted and ready to land.Feb 21 2019, 2:59 AM
segfaultxavi requested changes to this revision.Feb 21 2019, 7:43 AM

Something went wrong. screen_scale_factor appears twice in the file now.

This revision now requires changes to proceed.Feb 21 2019, 7:43 AM
segfaultxavi accepted this revision.Feb 21 2019, 9:19 AM
This revision is now accepted and ready to land.Feb 21 2019, 9:19 AM
This revision was automatically updated to reflect the committed changes.