Details
- Reviewers
segfaultxavi - Maniphest Tasks
- T7590: efl.screen
- Commits
- rEFL606b0381c184: efl.screen: add screen_scale_factor property
Diff Detail
- Repository
- rEFL core/efl
- Branch
- master
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 9549
It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/
| src/lib/efl/interfaces/efl_screen.eo | ||
|---|---|---|
| 37 | How does the user know if this information is available or not? Say something like "the return value will be [0,0] if unknown". Also, scale factors can be extremely confusing. A scale of 2 means that I need to scale my values by two to get the same results, or that EFL will scale my values by two so everything will be twice as large? | |
| src/lib/efl/interfaces/efl_screen.eo | ||
|---|---|---|
| 37 | Oh actually this should return a double/float, so good catch on the first part. I think scaling is a case-by-case kind of thing? If you want something to scale then you need to multiply any absolute sizes that you set by the elm_config scale value (no idea what this is in interfaces api). The value here probably isn't directly used by anything since, based on how efl is trying to be implemented, the user should be setting a global 'scaling' factor which will be entirely arbitrary. | |