Page MenuHomePhabricator

eo: make reflection getter const function.
ClosedPublic

Authored by cedric on Feb 15 2019, 3:05 PM.

Details

Summary

Getter are usually not modifying there object. This is going to put a strong
limit on what a getter property for MVVM is, as it will prevent any side
effect on getting a property from a View.

Depends on D7946

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Feb 15 2019, 3:05 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

cedric requested review of this revision.Feb 15 2019, 3:05 PM
bu5hm4n requested changes to this revision.Feb 16 2019, 1:10 AM
bu5hm4n added a subscriber: bu5hm4n.
bu5hm4n added inline comments.
src/lib/eo/Eo.h
2000

Please also add here a const :)

This revision now requires changes to proceed.Feb 16 2019, 1:10 AM
cedric updated this revision to Diff 19785.Wed, Feb 27, 1:40 PM
cedric edited the summary of this revision. (Show Details)

Rebase and be more const.

cedric updated this revision to Diff 19869.Fri, Mar 1, 10:39 AM

Rebase.

cedric updated this revision to Diff 20055.Wed, Mar 6, 3:42 PM

Rebase.

segfaultxavi accepted this revision.Thu, Mar 7, 2:15 AM
segfaultxavi added a subscriber: segfaultxavi.

Makes a lot of sense.

cedric updated this revision to Diff 20274.Thu, Mar 7, 4:02 PM

Rebase with massive amount of new const added after mike patches.

segfaultxavi accepted this revision.Fri, Mar 8, 6:22 AM

Everything still builds, so these consts do not break any existing code, and it makes sense that getters do not modify objects. Only getter functions are modified. Approving again.

This revision is now accepted and ready to land.Fri, Mar 8, 6:24 AM
cedric updated this revision to Diff 20342.Fri, Mar 8, 1:58 PM

Rebase.

This revision was automatically updated to reflect the committed changes.