Page MenuHomePhabricator

api: add bool data to efl.io.reader/writer 'changed' events
ClosedPublic

Authored by zmike on Feb 21 2019, 9:36 AM.

Details

Summary

changed events should always be triggered with the accompanying changed
data to reduce function calls

ref T7600, T7599

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Feb 21 2019, 9:36 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Feb 21 2019, 9:36 AM
cedric accepted this revision.Feb 21 2019, 9:41 AM

I think it is ok to directly send a bool type instead of structure that contain a bool. In C, you can just if on the pointer without doing any conversion and binding should be fine making it a boolean. I also do not forsee us adding new data to that event, so it should be fine if it is not extensible.

This revision is now accepted and ready to land.Feb 21 2019, 9:41 AM
This revision was automatically updated to reflect the committed changes.