Page MenuHomePhabricator

api: rename efl.gfx.entity geometry events and add geometry data to those events
ClosedPublic

Authored by zmike on Feb 21 2019, 10:03 AM.

Details

Summary

the convention for event naming is to use $property,changed where possible
and to always emit related data with the event to reduce function calls

ref T7558

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Feb 21 2019, 10:03 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Feb 21 2019, 10:03 AM
cedric added inline comments.
src/lib/efl/interfaces/efl_gfx_entity.eo
106–107

That might actually be incorrect. I am not sure, need the opinion of @q66 or @bu5hm4n on this, but do we expect a pointer to an Eina.Position2D in this situation or not? If we do, what about the case with simple type?

I think we talked about that, but I forgot the answer, the legacy event "move" and "resize", where are they emitted now?

src/lib/efl/interfaces/efl_gfx_entity.eo
106–107

I think a great great wizard appears here and makes the Eina.Position2D a pointer. On the fly. Without a warning.

bu5hm4n accepted this revision.Feb 22 2019, 1:09 AM
This revision is now accepted and ready to land.Feb 22 2019, 1:09 AM
Closed by commit rEFLa08570fdae9f: api: rename efl.gfx.entity geometry events and add geometry data to those events (authored by zmike, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyFeb 22 2019, 1:10 AM
This revision was automatically updated to reflect the committed changes.