Page MenuHomePhabricator

eo: mark efl_object stable
ClosedPublic

Authored by bu5hm4n on Feb 22 2019, 5:37 AM.

Details

Summary

fix T7557

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Feb 22 2019, 5:37 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

bu5hm4n requested review of this revision.Feb 22 2019, 5:37 AM

Can you add @since 1.22 at the same time that you remove the @beta from the class? (as suggested in T7704).

bu5hm4n updated this revision to Diff 19794.Thu, Feb 28, 1:38 AM
bu5hm4n edited the summary of this revision. (Show Details)

The change make sense, just the missing and updated @since.

bu5hm4n updated this revision to Diff 19956.Wed, Mar 6, 10:26 AM

since since since since!

cedric requested changes to this revision.Wed, Mar 6, 10:36 AM
cedric added inline comments.
src/lib/eo/efl_object.eo
135–136

I think this one should be 1.22, no ? Or maybe just plain removed.

This revision now requires changes to proceed.Wed, Mar 6, 10:36 AM
bu5hm4n updated this revision to Diff 19958.Wed, Mar 6, 10:49 AM

remove unncessasary since

cedric accepted this revision.Wed, Mar 6, 10:53 AM
This revision is now accepted and ready to land.Wed, Mar 6, 10:53 AM
Closed by commit rEFL999ed5f200d1: eo: mark efl_object stable (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by cedric). · Explain WhyWed, Mar 6, 11:39 AM
This revision was automatically updated to reflect the committed changes.