- Maniphest Tasks
- T7558: efl.gfx.entity
- rEFL5da43b2aa773: efl.gfx.entity: combine show/hide events into visibility,changed
It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/
Builds without warnings and a random sample of tests continue working as expected.
Just those minor inline comments.
I'd also rename the method to _pop_content_visibility_changed_cb. Otherwise it's confusing.
What happened to move and resize events? Why do they disappear here?
It's for the purpose of catching the hidden state though, so imo this still fits.
Those shouldn't have been pushed in to begin with, so the fact that I was able to just rename dead code and put it to use is a happy accident.
You might hate me now, but this is not obvious, that this means that the object is beeing shown, can you just call efl_gfx_visibility_get ? that would IMO improve this quality wise a lot.