Page MenuHomePhabricator

efl_ui : renaming list_view sub classes.
Needs RevisionPublic

Authored by SanghyeonLee on Feb 25 2019, 8:44 PM.

Details

Summary

sub class of list_view can have better name on their purpose.

Efl.Ui.List_View_Model -> Efl.Ui.List_View_Model_Manager
reason : This interface is helper class for managing model data on the listview not a model class.

Efl.Ui.List_View_Relayout -> Efl.Ui.List_View_Layouter
reason : This interface is an layouter to relayouting elements of the view like precise_layouter or homogeneous_layouter.
for the unity, it could be better to using noun name layouter.

Test Plan

N/A

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9710
Build 8054: arc lint + arc unit
SanghyeonLee created this revision.Feb 25 2019, 8:44 PM
SanghyeonLee requested review of this revision.Feb 25 2019, 8:44 PM

remove unwanted files

cedric added a comment.Mar 1 2019, 3:25 PM

I am not to sure of the name layouter. As this is a private class, we really do not need to care about it at this point.

As for renaming to model_manager, it is indeed a less bad option than what we currently have. So we should get that in now.

cedric requested changes to this revision.Mar 1 2019, 3:25 PM
This revision now requires changes to proceed.Mar 1 2019, 3:25 PM