Page MenuHomePhabricator

evas_object_main: use eina_list_append instead of eina_list_prepend.
Needs RevisionPublic

Authored by eagleeye on Feb 26 2019, 4:37 AM.

Details

Summary

In evas_render_pre() visibility state of object is changed.
But list is iterated in reverse order of creation.
So there is problem that the last item is focused.

Test Plan

elementary_test -> efl.ui.scroller

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9721
eagleeye created this revision.Feb 26 2019, 4:37 AM
eagleeye requested review of this revision.Feb 26 2019, 4:37 AM
zmike added a subscriber: zmike.Mar 4 2019, 6:44 AM

Can a unit test be added to verify the behavior you're expecting to be fixed with this patch?

zmike requested changes to this revision.Mar 8 2019, 5:31 AM

I guess I'm not going to get a reply unless I reject the patch.

This revision now requires changes to proceed.Mar 8 2019, 5:31 AM

Now "make check" is not working. This is my test result.
Do you know why unit test is not working now?

Testsuite summary for efl 1.22.0-beta2

  1. TOTAL: 0
  2. PASS: 0
  3. SKIP: 0
  4. XFAIL: 0
  5. FAIL: 0
  6. XPASS: 0
  7. ERROR: 0

Now "make check" is not working. This is my test result.
Do you know why unit test is not working now?

============================================================================
Testsuite summary for efl 1.22.0-beta2
============================================================================

  1. TOTAL: 0
  2. PASS: 0
  3. SKIP: 0
  4. XFAIL: 0
  5. FAIL: 0
  6. XPASS: 0
  7. ERROR: 0 ============================================================================

This happen when we are in release mode, you have to explicitly enable tests at compile. Depends if you are using autotools or meson for the flags.

To create unit test for this commit, https://phab.enlightenment.org/D8528 is necessary.