Page MenuHomePhabricator

efl.file_save: rework save flags
ClosedPublic

Authored by zmike on Feb 27 2019, 7:09 AM.

Details

Summary

instead of passing a string which requires reading docs to know which
arbitrary string key=value sets can be passed, use an extensible struct
which contains more easily referenced values

ref T7672

Depends on D8035

Diff Detail

Repository
rEFL core/efl
Branch
arcpatch-D8039
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9766
Build 8062: arc lint + arc unit
zmike created this revision.Feb 27 2019, 7:09 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Feb 27 2019, 7:09 AM
zmike updated this revision to Diff 19726.Feb 27 2019, 8:29 AM
zmike edited the summary of this revision. (Show Details)

Except for the C# breakage, nice work!

I will update the diff.

src/lib/efl/interfaces/efl_file_save.eo
4

Efl.File_Save is a type (defined just below) so it cannot be a namespace here. Better use Efl.File_Save_Info?
(makes C# build to fail).

7

*image

zmike added a comment.Feb 27 2019, 9:18 AM

Except for the C# breakage, nice work!

I will update the diff.

I approve these changes.

Renamed Efl.File_Save.Save_Into to Efl.File_Save_Info so it does not cause namespace conflicts in C#.

Fix Phab mess

segfaultxavi accepted this revision.Feb 27 2019, 9:40 AM

Everything builds now.

This revision is now accepted and ready to land.Feb 27 2019, 9:40 AM
This revision was automatically updated to reflect the committed changes.