Page MenuHomePhabricator

elm_popup: remove on_show_region_set call
ClosedPublic

Authored by bu5hm4n on Feb 27 2019, 12:02 PM.

Details

Summary

Its hard to say why removing such calls are fixing a bug like T7274.
However, it appears that this call causes the min size calculation of
evas to fall apart. This also removes a workarround introduced earlier
to fix this.

This fixes T7274

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Feb 27 2019, 12:02 PM
bu5hm4n requested review of this revision.Feb 27 2019, 12:02 PM
zmike accepted this revision.Feb 28 2019, 5:48 AM

This is truly mind melting but I can't argue that it works.

This revision is now accepted and ready to land.Feb 28 2019, 5:48 AM
Closed by commit rEFLf76d04683b4d: elm_popup: remove on_show_region_set call (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by zmike). · Explain WhyFeb 28 2019, 5:49 AM
This revision was automatically updated to reflect the committed changes.