Page MenuHomePhabricator

efl.gfx: remove Efl.Gfx.Image_Load_Error
ClosedPublic

Authored by zmike on Feb 28 2019, 2:18 PM.

Details

Summary

this is now implemented through Eina.Error

ref T7718

Depends on D8066

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Feb 28 2019, 2:18 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Feb 28 2019, 2:18 PM
cedric added inline comments.Feb 28 2019, 3:17 PM
src/lib/evas/canvas/efl_canvas_image.c
46

What is that?

src/lib/evas/canvas/evas_main.c
38

I am not sure we would this symbol to be EWAPI. Why not just EAPI?

zmike updated this revision to Diff 19854.Mar 1 2019, 7:13 AM
zmike edited the summary of this revision. (Show Details)

remove copypasta

src/lib/evas/canvas/efl_canvas_image.c
46

That is nothing. You didn't see that.

src/lib/evas/canvas/evas_main.c
38

That's what eolian outputs it as in the header. Should it be EAPI here?

cedric added inline comments.Mar 1 2019, 8:58 AM
src/lib/evas/canvas/evas_main.c
38

I think so. EWAPI means that we can override the symbol (weak symbol) if I am correct. This make sense for function, but I don't think we want that here.

zmike updated this revision to Diff 19860.Mar 1 2019, 10:22 AM

make errors API

cedric accepted this revision.Mar 1 2019, 10:41 AM
This revision is now accepted and ready to land.Mar 1 2019, 10:41 AM
This revision was automatically updated to reflect the committed changes.