efl.gfx: remove Efl.Gfx.Image_Load_Error
ClosedPublic
Actions

Authored by zmike on Feb 28 2019, 2:18 PM.

Details

Reviewers

cedric

Maniphest Tasks

Commits

rEFL6b046ec845b6: efl.gfx: remove Efl.Gfx.Image_Load_Error

Summary

this is now implemented through Eina.Error

Depends on D8066

Repository

rEFL core/efl

Branch

master

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 9817

zmike created this revision.Feb 28 2019, 2:18 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Feb 28 2019, 2:18 PM

src/lib/evas/canvas/efl_canvas_image.c
46	What is that?
src/lib/evas/canvas/evas_main.c
38	I am not sure we would this symbol to be EWAPI. Why not just EAPI?

remove copypasta

src/lib/evas/canvas/efl_canvas_image.c
46	That is nothing. You didn't see that.
src/lib/evas/canvas/evas_main.c
38	That's what eolian outputs it as in the header. Should it be EAPI here?

src/lib/evas/canvas/evas_main.c
38	I think so. EWAPI means that we can override the symbol (weak symbol) if I am correct. This make sense for function, but I don't think we want that here.

make errors API

This revision is now accepted and ready to land.Mar 1 2019, 10:41 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
~			src/lib/edje/edje_load.c (2 lines)
~			src/lib/edje/efl_canvas_layout.eo (2 lines)
~			src/lib/efl/interfaces/efl_gfx_image.eo (2 lines)
~			src/lib/efl/interfaces/efl_gfx_image_load_controller.eo (2 lines)
~			src/lib/efl/interfaces/efl_gfx_types.eot (28 lines)
~			src/lib/evas/canvas/efl_canvas_image.c (11 lines)
~			src/lib/evas/canvas/efl_canvas_proxy.c (2 lines)
~			src/lib/evas/canvas/efl_canvas_scene3d.c (4 lines)
~			src/lib/evas/canvas/evas_image_legacy.c (21 lines)
~			src/lib/evas/canvas/evas_image_private.h (2 lines)
~			src/lib/evas/canvas/evas_main.c (97 lines)
~			src/lib/evas/canvas/evas_object_image.c (20 lines)
~			src/lib/evas/include/evas_common_private.h (2 lines)
~			src/lib/evas/include/evas_private.h (5 lines)
~			src/lib/evas/vg/evas_vg_cache.c (2 lines)
~			src/modules/evas/engines/gl_common/evas_gl_image.c (8 lines)
~			src/modules/evas/vg_savers/eet/evas_vg_save_eet.c (2 lines)
~			src/modules/evas/vg_savers/svg/evas_vg_save_svg.c (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	19840	f348c74		Feb 28 2019, 2:18 PM	★	★
Diff 2	19854	05ed085	remove copypasta	Mar 1 2019, 7:13 AM	★	★
Diff 3	19860	05ed085	make errors API	Mar 1 2019, 10:22 AM	★	★
Diff 4	19916	c388e85	rEFL6b046ec845b6e0dc5d87f8d6f6524d1794678727	Mar 4 2019, 10:36 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
8b77b8245cd3	59b1ce24cc54	f348c74ecbed	Mike Blumenkrantz	(Show More…)	Feb 28 2019, 1:52 PM

Status	Author	Revision
Closed	zmike	D8087 efl_ui_win: fix position,changed eventing
Closed	zmike	D8086 efl.ui.win: mark most stuff with @beta
Closed	zmike	D8085 efl.ui.win: remove 'noblank' property from eo api
Closed	zmike	D8084 efl.ui.win: remove keygrab set/unset from eo api
Closed	zmike	D8083 efl.ui.win: remove all legacy types and functions from eo file
Closed	zmike	D8082 efl.ui.widget: widget_event -> widget_input_event_handler
Closed	zmike	D8081 efl.ui.widget: mark a bunch of methods and event @beta
Closed	zmike	D8068 efl.ui: remove Efl.Ui.Theme_Apply_Error
Closed	zmike	D8067 efl.gfx: remove Efl.Gfx.Image_Load_Error
Closed	zmike	D8066 evas: remove linkage between Efl_Gfx_Image_Load_Error and Evas_Load_Error
Closed	zmike	D8064 efl.ui.widget: remove widget_top property
Closed	zmike	D8063 efl.ui: Efl.Ui.Theme_Apply_Result -> Efl.Ui.Theme_Apply_Error
Closed	zmike	D8060 efl.ui.layout: mark methods as beta
Closed	zmike	D8059 efl.ui.layout: fix theme.get implementation (+unit test)