Page MenuHomePhabricator

efl-mono: Add Model manual implementation to C# and MVVM factories
Needs ReviewPublic

Authored by felipealmeida on Feb 28 2019, 5:24 PM.

Diff Detail

Repository
rEFL core/efl
Branch
devs/felipealmeida/mono_model (branched from dotnet)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9830
Build 8081: arc lint + arc unit
felipealmeida created this revision.Feb 28 2019, 5:24 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

felipealmeida requested review of this revision.Feb 28 2019, 5:24 PM

Some initial comments

src/Makefile_Ecore.am
56

Are these required or would be under some if HAVE_CSHARP guard?

src/lib/ecore/meson.build
81

Are these required or could be under a check like if get_option('bindings').contains('mono')?

src/tests/efl_mono/Model.cs
24

Missing some checks here?

38

Use Test.Assert(condition) instead of Console.WriteLine.

48

Remove?

49

Check something after to confirm the property was bound?

src/tests/efl_mono/Parts.cs
23

Assert something later?

31

Dynamic get only?

is this patch ready to go?
please comment more detail about this patch in commit-message,
and rebase on latest master.

can you update status of this diff?