Page MenuHomePhabricator

ui.box_stack: refactor layout_update
ClosedPublic

Authored by YOhoho on Sun, Mar 3, 11:23 PM.

Details

Summary

This patch remove evas_box function from Efl.Ui.Box_Stack and add unit test.

Depends on D8214

Test Plan
  1. make check
  2. elementary_test -to 'efl.ui.box_stack'

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
YOhoho created this revision.Sun, Mar 3, 11:23 PM
YOhoho requested review of this revision.Sun, Mar 3, 11:23 PM
YOhoho planned changes to this revision.Mon, Mar 4, 7:37 PM
YOhoho updated this revision to Diff 20131.Thu, Mar 7, 3:06 AM

more unit test

YOhoho updated this revision to Diff 20132.Thu, Mar 7, 3:07 AM
YOhoho retitled this revision from efl_ui_box_stack: refactor layout_update to ui.box_stack: refactor layout_update.
YOhoho edited the summary of this revision. (Show Details)

Depends on D8214

cedric accepted this revision.Thu, Mar 7, 9:34 AM

Tests hero _o/ \o/ \o_ !

This revision is now accepted and ready to land.Thu, Mar 7, 9:34 AM
zmike requested changes to this revision.Fri, Mar 8, 5:22 AM

Needs rebasing

This revision now requires changes to proceed.Fri, Mar 8, 5:22 AM
zmike requested changes to this revision.Mon, Mar 18, 11:19 AM

Sorry I missed this when you updated...can you rebase one more time?

This revision now requires changes to proceed.Mon, Mar 18, 11:19 AM
YOhoho updated this revision to Diff 20714.Mon, Mar 18, 6:22 PM

Rebase and use restricted_min_set

@YOhoho

Could you tell me why memory initialization is required only for debugging mode?

src/lib/elementary/efl_ui_box_stack.c
44

It seems that there is a reason why this memory initialization is required only for debugging mode. But I don't know why..

Could you tell me the reason?

YOhoho added inline comments.Wed, Mar 20, 5:04 AM
src/lib/elementary/efl_ui_box_stack.c
44

I have no idea.. it is copied from efl_ui_box_layout.c:57 written by jpeg.

Jaehyun_Cho added inline comments.Wed, Mar 20, 5:08 AM
src/lib/elementary/efl_ui_box_stack.c
44

Thank you. It seems that it purely helps the debugging ;)

e.g. alloca() does not initialize memory so it seems that the initial dirty memory may make debugging difficult.

Jaehyun_Cho accepted this revision.Wed, Mar 20, 5:12 AM

rebase has been applied

zmike accepted this revision.Wed, Mar 20, 7:28 AM

Thanks!

This revision is now accepted and ready to land.Wed, Mar 20, 7:28 AM
Closed by commit rEFL77f2782d29eb: ui.box_stack: refactor layout_update (authored by Yeongjong Lee <yj34.lee@samsung.com>, committed by zmike). · Explain WhyWed, Mar 20, 7:37 AM
This revision was automatically updated to reflect the committed changes.