Differential D8094

ui.box_stack: refactor layout_update
ClosedPublic
Actions

Authored by YOhoho on Mar 3 2019, 11:23 PM.

Tags

Subscribers

cedric, reviewers, committers

Tokens

"Yellow Medal" token, awarded by segfaultxavi.

Details

Reviewers

zmike
Jaehyun_Cho
cedric

Commits

rEFL77f2782d29eb: ui.box_stack: refactor layout_update

Summary

This patch remove evas_box function from Efl.Ui.Box_Stack and add unit test.

Depends on D8214

Test Plan

make check
elementary_test -to 'efl.ui.box_stack'

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

YOhoho created this revision.Mar 3 2019, 11:23 PM

Herald added a project: efl. · View Herald TranscriptMar 3 2019, 11:23 PM

Herald added subscribers: committers, reviewers, cedric. · View Herald Transcript

YOhoho requested review of this revision.Mar 3 2019, 11:23 PM

Harbormaster completed remote builds in B9863: Diff 19899.Mar 3 2019, 11:23 PM

YOhoho planned changes to this revision.Mar 4 2019, 7:37 PM

more unit test

Harbormaster completed remote builds in B10032: Diff 20131.Mar 7 2019, 3:06 AM

Depends on D8214

Harbormaster completed remote builds in B10033: Diff 20132.Mar 7 2019, 3:08 AM

Tests hero _o/ \o/ \o_ !

This revision is now accepted and ready to land.Mar 7 2019, 9:34 AM

segfaultxavi awarded a token.Mar 7 2019, 9:35 AM

Needs rebasing

This revision now requires changes to proceed.Mar 8 2019, 5:22 AM

rebase

Harbormaster completed remote builds in B10164: Diff 20397.Mar 11 2019, 3:51 AM

Sorry I missed this when you updated...can you rebase one more time?

This revision now requires changes to proceed.Mar 18 2019, 11:19 AM

Rebase and use restricted_min_set

Harbormaster completed remote builds in B10405: Diff 20714.Mar 18 2019, 6:22 PM

YOhoho added a child revision: D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.Mar 19 2019, 9:54 PM

Could you tell me why memory initialization is required only for debugging mode?

src/lib/elementary/efl_ui_box_stack.c
44	It seems that there is a reason why this memory initialization is required only for debugging mode. But I don't know why.. Could you tell me the reason?

YOhoho added inline comments.Mar 20 2019, 5:04 AM

src/lib/elementary/efl_ui_box_stack.c
44	I have no idea.. it is copied from efl_ui_box_layout.c:57 written by jpeg.

Jaehyun_Cho added inline comments.Mar 20 2019, 5:08 AM

src/lib/elementary/efl_ui_box_stack.c
44	Thank you. It seems that it purely helps the debugging ;) e.g. alloca() does not initialize memory so it seems that the initial dirty memory may make debugging difficult.

rebase has been applied

Thanks!

This revision is now accepted and ready to land.Mar 20 2019, 7:28 AM

Closed by commit rEFL77f2782d29eb: ui.box_stack: refactor layout_update (authored by Yeongjong Lee <yj34.lee@samsung.com>, committed by zmike). · Explain WhyMar 20 2019, 7:37 AM

This revision was automatically updated to reflect the committed changes.

YOhoho removed a child revision: D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.Mar 20 2019, 9:53 PM

Revision Contents
Changeset List

			Path	Packages
M			src/Makefile_Elementary.am (2 lines)
M			src/bin/elementary/meson.build (1 line)
M			src/bin/elementary/test.c (4 lines)
M			src/bin/elementary/test_box.c (41 lines)
A	M		src/bin/elementary/test_ui_box_stack.c (44 lines)
M			src/lib/elementary/efl_ui_box_stack.c (87 lines)
M			src/tests/elementary/efl_ui_suite.h (1 line)
M			src/tests/elementary/efl_ui_suite.c (1 line)
A	M		src/tests/elementary/efl_ui_test_box_stack.c (244 lines)
M			src/tests/elementary/meson.build (1 line)

Diff 20792

src/Makefile_Elementary.am

Loading...

src/bin/elementary/meson.build

Loading...

src/bin/elementary/test.c

Loading...

src/bin/elementary/test_box.c

Loading...

src/bin/elementary/test_ui_box_stack.c

Loading...

src/lib/elementary/efl_ui_box_stack.c

Loading...

src/tests/elementary/efl_ui_suite.h

Loading...

src/tests/elementary/efl_ui_suite.c

Loading...

src/tests/elementary/efl_ui_test_box_stack.c

Loading...

src/tests/elementary/meson.build

Loading...