Page MenuHomePhabricator
Differential D8094

ui.box_stack: refactor layout_update
ClosedPublic
Actions

Authored by YOhoho on Mar 3 2019, 11:23 PM.

Details

Reviewers
zmike
Jaehyun_Cho
cedric
Commits
rEFL77f2782d29eb: ui.box_stack: refactor layout_update
Summary

This patch remove evas_box function from Efl.Ui.Box_Stack and add unit test.

Depends on D8214

Test Plan
  1. make check
  2. elementary_test -to 'efl.ui.box_stack'

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10164
Build 8165: arc lint + arc unit
YOhoho created this revision.Mar 3 2019, 11:23 PM
YOhoho requested review of this revision.Mar 3 2019, 11:23 PM
YOhoho planned changes to this revision.Mar 4 2019, 7:37 PM
YOhoho updated this revision to Diff 20131.Mar 7 2019, 3:06 AM

more unit test

YOhoho updated this revision to Diff 20132.Mar 7 2019, 3:07 AM
YOhoho retitled this revision from efl_ui_box_stack: refactor layout_update to ui.box_stack: refactor layout_update.
YOhoho edited the summary of this revision. (Show Details)
YOhoho added a parent revision: D8214: ui.box, ui.table: respect user min.

Depends on D8214

cedric accepted this revision.Mar 7 2019, 9:34 AM

Tests hero _o/ \o/ \o_ !

This revision is now accepted and ready to land.Mar 7 2019, 9:34 AM
zmike requested changes to this revision.Mar 8 2019, 5:22 AM

Needs rebasing

This revision now requires changes to proceed.Mar 8 2019, 5:22 AM
zmike requested changes to this revision.Mar 18 2019, 11:19 AM

Sorry I missed this when you updated...can you rebase one more time?

This revision now requires changes to proceed.Mar 18 2019, 11:19 AM
YOhoho updated this revision to Diff 20714.Mar 18 2019, 6:22 PM

Rebase and use restricted_min_set

Jaehyun_Cho added a comment.Mar 20 2019, 4:55 AM

@YOhoho

Could you tell me why memory initialization is required only for debugging mode?

src/lib/elementary/efl_ui_box_stack.c
44

It seems that there is a reason why this memory initialization is required only for debugging mode. But I don't know why..

Could you tell me the reason?

YOhoho added inline comments.Mar 20 2019, 5:04 AM
src/lib/elementary/efl_ui_box_stack.c
44

I have no idea.. it is copied from efl_ui_box_layout.c:57 written by jpeg.

Jaehyun_Cho added inline comments.Mar 20 2019, 5:08 AM
src/lib/elementary/efl_ui_box_stack.c
44

Thank you. It seems that it purely helps the debugging ;)

e.g. alloca() does not initialize memory so it seems that the initial dirty memory may make debugging difficult.

Jaehyun_Cho accepted this revision.Mar 20 2019, 5:12 AM

rebase has been applied

zmike accepted this revision.Mar 20 2019, 7:28 AM

Thanks!

This revision is now accepted and ready to land.Mar 20 2019, 7:28 AM
Closed by commit rEFL77f2782d29eb: ui.box_stack: refactor layout_update (authored by Yeongjong Lee <yj34.lee@samsung.com>, committed by zmike). · Explain WhyMar 20 2019, 7:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 20397

View Options

src/Makefile_Elementary.am

Loading...
View Options

src/bin/elementary/meson.build

Loading...
View Options

src/bin/elementary/test.c

Loading...
View Options

src/bin/elementary/test_box.c

Loading...
View Options

src/bin/elementary/test_ui_box_stack.c

Loading...
View Options

src/lib/elementary/efl_ui_box_stack.c

Loading...
View Options

src/tests/elementary/efl_ui_suite.h

Loading...
View Options

src/tests/elementary/efl_ui_suite.c

Loading...
View Options

src/tests/elementary/efl_ui_test_box_stack.c

Loading...
View Options

src/tests/elementary/meson.build

Loading...