Page MenuHomePhabricator

efl_ui_win: remove accel_preference and win_type from constructors
AbandonedPublic

Authored by woohyun on Mar 5 2019, 12:40 AM.

Details

Summary

After marking @beta to accel_preference and win_type, these properties
are not generated as EFL# methods any more. And, building EFL# is failed
because constructors are still including these properties.

I think these properties need to be removed from constructors while
they are @beta.

Test Plan

./autogen.sh --enable-csharp-bindings; make

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9876
Build 8099: arc lint + arc unit
woohyun created this revision.Mar 5 2019, 12:40 AM
woohyun requested review of this revision.Mar 5 2019, 12:40 AM

I just created T7723 to fix this issue.

I think the proper solution is to fix the constructor so that it does not include @beta properties if the bindings are being built without beta support.

Meanwhile, you can request beta support when building the C# bindings (-Dmono-beta=true in meson or --enable-csharp-beta with autotools).

woohyun abandoned this revision.Mar 7 2019, 9:38 PM

@segfaultxavi

Thank you for handling this with proper way : ) So, I abandoned.