elm_clock: remove all legacy usage from eo files
ClosedPublic
Actions

Authored by zmike on Mar 6 2019, 3:18 PM.

Details

Reviewers

cedric
q66

Maniphest Tasks

T7724: split out legacy from eo files

Commits

rEFLf549d1c2718f: elm_clock: remove all legacy usage from eo files

Summary

this takes the current generated output from eolian for legacy code in
efl and adds it to the tree, then removes legacy references from the
corresponding eo files. in the case where the entire eo file was for
a legacy object, that eo file has been removed from the tree

ref T7724

Depends on D8156

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

zmike created this revision.Mar 6 2019, 3:18 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Mar 6 2019, 3:18 PM

zmike added a child revision: D8158: elm_code_widget: make this efl_ui namespaced.

Harbormaster completed remote builds in B9937: Diff 20024.Mar 6 2019, 3:23 PM

cedric requested changes to this revision.Mar 6 2019, 4:09 PM

cedric added inline comments.

src/lib/elementary/meson.build
730	I think that this header shouldn't be actually installed. Same story as the rest, it never was included in Elementary.h.

This revision now requires changes to proceed.Mar 6 2019, 4:09 PM

rebase

Harbormaster completed remote builds in B9964: Diff 20062.Mar 6 2019, 5:05 PM

q66 accepted this revision.Mar 7 2019, 5:26 AM

cedric accepted this revision.Mar 7 2019, 12:30 PM

This revision is now accepted and ready to land.Mar 7 2019, 12:30 PM

Closed by commit rEFLf549d1c2718f: elm_clock: remove all legacy usage from eo files (authored by zmike, committed by cedric). · Explain WhyMar 7 2019, 2:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/Makefile_Elementary.am (5 lines)
M		src/lib/elementary/elm_clock.c (2 lines)
D	M	src/lib/elementary/elm_clock.eo (172 lines)
M		src/lib/elementary/elm_clock_eo.h (305 lines)
A	M	src/lib/elementary/elm_clock_eo.c (249 lines)
A	M	src/lib/elementary/elm_clock_eo.legacy.h (281 lines)
A	M	src/lib/elementary/elm_clock_eo.legacy.c (84 lines)
M		src/lib/elementary/elm_clock_legacy.h (2 lines)
M		src/lib/elementary/elm_widget_clock.h (2 lines)
M		src/lib/elementary/meson.build (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	20024	c6ed30c		Mar 6 2019, 3:18 PM	★	★
Diff 2	20062	b6f8479	rebase	Mar 6 2019, 5:02 PM	★	★
Diff 3	20183	1f24b03	rEFLf549d1c2718fa9250a8f4463bcb010eb77ee4794	Mar 7 2019, 2:14 PM	★	★

Status	Author	Revision
Closed	zmike	D8233 elm: unfuck public headers (only a little)
Closed	zmike	D8232 elm_fileselector: some misc include fixes for compiling
Closed	zmike	D8231 elm_win: attempt to fix legacy header
Closed	zmike	D8230 elm: fix legacy headers to never include (non-installed) eo headers
Closed	zmike	D8229 elm_interface_scrollable: remove elm_pan_eo.h from public header
Closed	zmike	D8228 elm_priv.h: add includes. lots of includes.
Closed	zmike	D8227 elm_slider_part_indicator: remove eo type usage from legacy functions
Closed	zmike	D8226 elm: remove legacy type usage from eo focus functions
Closed	zmike	D8225 elm_widget: remove usage of eo types in legacy functions
Closed	zmike	D8224 elm_general: remove linkage between legacy enums and eo types
Closed	zmike	D8223 elm: explicitly include Efl_Ui.h in binaries
Closed	zmike	D8222 build: ensure correct headers are installed
Closed	zmike	D8221 remove header
Closed	zmike	D8213 efl_ui_flip: finish legacy removal from eo
Closed	zmike	D8212 build: don't distribute eo headers legacy elm widgets
Closed	zmike	D8211 elm: remove all legacy usage from eo files
Closed	zmike	D8210 efl_ui_focus_parent_provider_gen: remove all legacy usage from eo files
Closed	zmike	D8209 elm_widget_item*: remove all legacy usage from eo files
Closed	zmike	D8208 elm_web: remove all legacy usage from eo files
Closed	zmike	D8207 elm_view*: remove all legacy usage from eo files
Closed	zmike	D8206 elm_toolbar*: remove all legacy usage from eo files
Closed	zmike	D8205 elm_thumb: remove all legacy usage from eo files
Closed	zmike	D8204 elm_table: remove all legacy usage from eo files
Closed	zmike	D8203 elm_systray: remove all legacy usage from eo files
Closed	zmike	D8202 elm_sys_notify*: remove all legacy usage from eo files
Closed	zmike	D8201 elm_spinner: remove all legacy usage from eo files
Closed	zmike	D8200 elm_slideshow*: remove all legacy usage from eo files
Closed	zmike	D8199 elm_slider*: remove all legacy usage from eo files
Closed	zmike	D8198 elm_separator: remove all legacy usage from eo files
Closed	zmike	D8197 elm_segment_control*: remove all legacy usage from eo files
Closed	zmike	D8196 elm_scroller: remove all legacy usage from eo files
Closed	zmike	D8195 elm_route: remove all legacy usage from eo files
Closed	zmike	D8194 elm_prefs: remove all legacy usage from eo files
Closed	zmike	D8193 elm_popup*: remove all legacy usage from eo files
Closed	zmike	D8192 elm_plug: remove all legacy usage from eo files
Closed	zmike	D8191 elm_player: remove all legacy usage from eo files
Closed	zmike	D8190 elm_photo: remove all legacy usage from eo files
Closed	zmike	D8189 elm_pan: remove all legacy usage from eo files
Closed	zmike	D8188 elm_panel: remove all legacy usage from eo files
Closed	zmike	D8187 elm_notify: remove all legacy usage from eo files
Closed	zmike	D8186 elm_naviframe*: remove all legacy usage from eo files
Closed	zmike	D8185 elm_multibuttonentry*: remove all legacy usage from eo files
Closed	zmike	D8184 elm_menu*: remove all legacy usage from eo files
Closed	zmike	D8183 elm_map: remove all legacy usage from eo files
Closed	zmike	D8182 elm_mapbuf: remove all legacy usage from eo files
Closed	zmike	D8181 elm_list: remove all legacy usage from eo files
Closed	zmike	D8180 elm_label: remove all legacy usage from eo files
Closed	zmike	D8179 elm_inwin: remove all legacy usage from eo files
Closed	zmike	D8178 elm_interface_fileselector: remove all legacy usage from eo files
Closed	zmike	D8177 elm_index: remove all legacy usage from eo files
Closed	zmike	D8176 elm_icon: remove all legacy usage from eo files
Closed	zmike	D8175 elm_hover: remove all legacy usage from eo files
Closed	zmike	D8174 elm_grid: remove all legacy usage from eo files
Closed	zmike	D8173 elm_glview: remove all legacy usage from eo files
Closed	zmike	D8172 elm_gesture_layer: remove all legacy usage from eo files
Closed	zmike	D8171 elm_genlist*: remove all legacy usage from eo files
Closed	zmike	D8169 elm_gengrid*: remove all legacy usage from eo files
Closed	zmike	D8168 elm_flipselector*: remove all legacy usage from eo files
Closed	zmike	D8167 elm_fileselector*: remove all legacy usage from eo files
Closed	zmike	D8166 elm_entry: remove all legacy usage from eo files
Closed	zmike	D8165 elm_diskselector: remove all legacy usage from eo files
Closed	zmike	D8164 elm_dayselector: remove all legacy usage from eo files
Closed	zmike	D8163 elm_ctxpopup: remove all legacy usage from eo files
Closed	zmike	D8162 elm_conformant: remove all legacy usage from eo files
Closed	zmike	D8161 elm_colorselector: remove all legacy usage from eo files
Closed	zmike	D8160 elm_color_item: remove all legacy usage from eo files
Closed	zmike	D8159 elm_code_widget_legacy: remove all legacy usage from eo files
Closed	zmike	D8158 elm_code_widget: make this efl_ui namespaced
Closed	zmike	D8157 elm_clock: remove all legacy usage from eo files
Closed	zmike	D8156 elm_calendar: remove all legacy usage from eo files
Closed	zmike	D8155 elm_bubble: remove all legacy usage from eo files
Closed	zmike	D8154 elm_box: remove all legacy usage from eo files
Closed	zmike	D8153 elm_actionslider: remove all legacy usage from eo files
Closed	zmike	D8152 elm_access: remove all legacy usage from eo files