elm_code_widget: make this efl_ui namespaced
ClosedPublic
Actions

Authored by zmike on Mar 6 2019, 3:19 PM.

Details

Reviewers

Commits

rEFLca9daf94c631: elm_code_widget: make this efl_ui namespaced

Summary

this currently has no counterpart in interface widgets but would be
useful there. removing the use of an elm_scroller type makes it independent
of legacy widgets, and it's still a beta api so at least future development
can be resumed at some point without much issue

Depends on D8157

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

zmike created this revision.Mar 6 2019, 3:19 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Mar 6 2019, 3:19 PM

zmike added a child revision: D8159: elm_code_widget_legacy: remove all legacy usage from eo files.

Harbormaster completed remote builds in B9938: Diff 20025.Mar 6 2019, 3:23 PM

cedric accepted this revision.Mar 6 2019, 4:11 PM

This revision is now accepted and ready to land.Mar 6 2019, 4:11 PM

rebase

Harbormaster completed remote builds in B9965: Diff 20063.Mar 6 2019, 5:05 PM

update with https://github.com/lauromoura/efl/commit/6bfd6361dc336ad77c9fd8bc141f4ecfd89b903a

Harbormaster completed remote builds in B10035: Diff 20135.Mar 7 2019, 5:09 AM

Closed by commit rEFLca9daf94c631: elm_code_widget: make this efl_ui namespaced (authored by zmike, committed by cedric). · Explain WhyMar 7 2019, 2:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/Makefile_Elementary.am (2 lines)
M		src/bin/elementary/test_code.c (42 lines)
M		src/lib/elementary/elm_code_diff_widget.c (8 lines)
M		src/lib/elementary/elm_code_widget.c (69 lines)
M		src/lib/elementary/elm_code_widget.eo (20 lines)
A	M	src/lib/elementary/elm_code_widget_eo.legacy.h (550 lines)
A	M	src/lib/elementary/elm_code_widget_eo.legacy.c (270 lines)
M		src/lib/elementary/elm_code_widget_legacy.h (2 lines)
M		src/lib/elementary/elm_code_widget_selection.c (18 lines)
M		src/lib/elementary/elm_code_widget_text.c (12 lines)
M		src/lib/elementary/elm_code_widget_undo.c (4 lines)
M		src/lib/elementary/meson.build (1 line)
M		src/tests/elementary/elm_code_test_syntax.c (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	20025	ee100f1		Mar 6 2019, 3:18 PM	★	★
Diff 2	20063	eb712aa	rebase	Mar 6 2019, 5:03 PM	★	★
Diff 3	20135	3cfff92	update with https://github.com/lauromoura/efl/commit/6bfd6361dc336ad77c9fd8bc14…	Mar 7 2019, 5:09 AM	★	★
Diff 4	20184	f549d1c	rEFLca9daf94c63178bd1ebf726b746e210bb9a0143d	Mar 7 2019, 2:14 PM	★	★

Status	Author	Revision
Closed	zmike	D8233 elm: unfuck public headers (only a little)
Closed	zmike	D8232 elm_fileselector: some misc include fixes for compiling
Closed	zmike	D8231 elm_win: attempt to fix legacy header
Closed	zmike	D8230 elm: fix legacy headers to never include (non-installed) eo headers
Closed	zmike	D8229 elm_interface_scrollable: remove elm_pan_eo.h from public header
Closed	zmike	D8228 elm_priv.h: add includes. lots of includes.
Closed	zmike	D8227 elm_slider_part_indicator: remove eo type usage from legacy functions
Closed	zmike	D8226 elm: remove legacy type usage from eo focus functions
Closed	zmike	D8225 elm_widget: remove usage of eo types in legacy functions
Closed	zmike	D8224 elm_general: remove linkage between legacy enums and eo types
Closed	zmike	D8223 elm: explicitly include Efl_Ui.h in binaries
Closed	zmike	D8222 build: ensure correct headers are installed
Closed	zmike	D8221 remove header
Closed	zmike	D8213 efl_ui_flip: finish legacy removal from eo
Closed	zmike	D8212 build: don't distribute eo headers legacy elm widgets
Closed	zmike	D8211 elm: remove all legacy usage from eo files
Closed	zmike	D8210 efl_ui_focus_parent_provider_gen: remove all legacy usage from eo files
Closed	zmike	D8209 elm_widget_item*: remove all legacy usage from eo files
Closed	zmike	D8208 elm_web: remove all legacy usage from eo files
Closed	zmike	D8207 elm_view*: remove all legacy usage from eo files
Closed	zmike	D8206 elm_toolbar*: remove all legacy usage from eo files
Closed	zmike	D8205 elm_thumb: remove all legacy usage from eo files
Closed	zmike	D8204 elm_table: remove all legacy usage from eo files
Closed	zmike	D8203 elm_systray: remove all legacy usage from eo files
Closed	zmike	D8202 elm_sys_notify*: remove all legacy usage from eo files
Closed	zmike	D8201 elm_spinner: remove all legacy usage from eo files
Closed	zmike	D8200 elm_slideshow*: remove all legacy usage from eo files
Closed	zmike	D8199 elm_slider*: remove all legacy usage from eo files
Closed	zmike	D8198 elm_separator: remove all legacy usage from eo files
Closed	zmike	D8197 elm_segment_control*: remove all legacy usage from eo files
Closed	zmike	D8196 elm_scroller: remove all legacy usage from eo files
Closed	zmike	D8195 elm_route: remove all legacy usage from eo files
Closed	zmike	D8194 elm_prefs: remove all legacy usage from eo files
Closed	zmike	D8193 elm_popup*: remove all legacy usage from eo files
Closed	zmike	D8192 elm_plug: remove all legacy usage from eo files
Closed	zmike	D8191 elm_player: remove all legacy usage from eo files
Closed	zmike	D8190 elm_photo: remove all legacy usage from eo files
Closed	zmike	D8189 elm_pan: remove all legacy usage from eo files
Closed	zmike	D8188 elm_panel: remove all legacy usage from eo files
Closed	zmike	D8187 elm_notify: remove all legacy usage from eo files
Closed	zmike	D8186 elm_naviframe*: remove all legacy usage from eo files
Closed	zmike	D8185 elm_multibuttonentry*: remove all legacy usage from eo files
Closed	zmike	D8184 elm_menu*: remove all legacy usage from eo files
Closed	zmike	D8183 elm_map: remove all legacy usage from eo files
Closed	zmike	D8182 elm_mapbuf: remove all legacy usage from eo files
Closed	zmike	D8181 elm_list: remove all legacy usage from eo files
Closed	zmike	D8180 elm_label: remove all legacy usage from eo files
Closed	zmike	D8179 elm_inwin: remove all legacy usage from eo files
Closed	zmike	D8178 elm_interface_fileselector: remove all legacy usage from eo files
Closed	zmike	D8177 elm_index: remove all legacy usage from eo files
Closed	zmike	D8176 elm_icon: remove all legacy usage from eo files
Closed	zmike	D8175 elm_hover: remove all legacy usage from eo files
Closed	zmike	D8174 elm_grid: remove all legacy usage from eo files
Closed	zmike	D8173 elm_glview: remove all legacy usage from eo files
Closed	zmike	D8172 elm_gesture_layer: remove all legacy usage from eo files
Closed	zmike	D8171 elm_genlist*: remove all legacy usage from eo files
Closed	zmike	D8169 elm_gengrid*: remove all legacy usage from eo files
Closed	zmike	D8168 elm_flipselector*: remove all legacy usage from eo files
Closed	zmike	D8167 elm_fileselector*: remove all legacy usage from eo files
Closed	zmike	D8166 elm_entry: remove all legacy usage from eo files
Closed	zmike	D8165 elm_diskselector: remove all legacy usage from eo files
Closed	zmike	D8164 elm_dayselector: remove all legacy usage from eo files
Closed	zmike	D8163 elm_ctxpopup: remove all legacy usage from eo files
Closed	zmike	D8162 elm_conformant: remove all legacy usage from eo files
Closed	zmike	D8161 elm_colorselector: remove all legacy usage from eo files
Closed	zmike	D8160 elm_color_item: remove all legacy usage from eo files
Closed	zmike	D8159 elm_code_widget_legacy: remove all legacy usage from eo files
Closed	zmike	D8158 elm_code_widget: make this efl_ui namespaced
Closed	zmike	D8157 elm_clock: remove all legacy usage from eo files
Closed	zmike	D8156 elm_calendar: remove all legacy usage from eo files
Closed	zmike	D8155 elm_bubble: remove all legacy usage from eo files
Closed	zmike	D8154 elm_box: remove all legacy usage from eo files
Closed	zmike	D8153 elm_actionslider: remove all legacy usage from eo files
Closed	zmike	D8152 elm_access: remove all legacy usage from eo files