Page MenuHomePhabricator

ui.box, ui.table: respect user min
ClosedPublic

Authored by YOhoho on Mar 6 2019, 5:32 PM.

Details

Summary

Use restricted_min_set instead of min_set in layout_update.
min_set is set by public API(user side). if it is changed by internal function,
user will get unexpected value later. please check added test case.

Note that this reverts commit e013480e7a0ae11a9363f9a207cf63e3bb7f5423. instead,
this patch provides better solution of the issue refered in e013480e7.

Depends on D8170

Test Plan

make check

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10021
Build 8108: arc lint + arc unit
YOhoho created this revision.Mar 6 2019, 5:32 PM
YOhoho requested review of this revision.Mar 6 2019, 5:32 PM
YOhoho updated this revision to Diff 20120.Mar 6 2019, 5:39 PM
YOhoho edited the summary of this revision. (Show Details)

Depends on D8170

YOhoho updated this revision to Diff 20121.Mar 6 2019, 5:40 PM

Depends on D8170

segfaultxavi accepted this revision.Mar 7 2019, 2:28 AM

Tutorial examples containing Box and Table continue to work as expected :)

This revision is now accepted and ready to land.Mar 7 2019, 2:28 AM
Closed by commit rEFL0b7cd8d88ec2: ui.box, ui.table: respect user min (authored by Yeongjong Lee <yj34.lee@samsung.com>, committed by cedric). · Explain WhyMar 7 2019, 9:59 AM
This revision was automatically updated to reflect the committed changes.