Page MenuHomePhabricator

ui.box,table: update layout when homogeneous mode is changed.
ClosedPublic

Authored by YOhoho on Mar 7 2019, 2:13 AM.

Details

Summary

changing homogeneous mode is needed layout_update.

Test Plan
  1. elementary_test -to 'efl.ui.box'
  2. Click 'Homogenous' check box.
  3. Check layout is updated.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
YOhoho created this revision.Mar 7 2019, 2:13 AM
YOhoho requested review of this revision.Mar 7 2019, 2:13 AM

elementary_test -to efl.ui.box does not work for me with or without this patch. I get this error when I tick the Homogeneous checkbox:

src/lib/elementary/efl_ui_box_flow.eo.c:20 efl_ui_box_flow_homogenous_set() Unable to resolve op for api func 0x7fcb1c01eb42 for obj=0x400000d89abe (Efl.Ui.Box)

And nothing changes on the screen.

NOTE: Clicking the Flow checkbox had all kinds of effects, from segfaulting to rebooting my machine.

YOhoho added a comment.Mar 7 2019, 3:17 AM
This comment was removed by YOhoho.
YOhoho added a comment.Mar 7 2019, 3:22 AM

elementary_test -to efl.ui.box does not work for me with or without this patch. I get this error when I tick the Homogeneous checkbox:

src/lib/elementary/efl_ui_box_flow.eo.c:20 efl_ui_box_flow_homogenous_set() Unable to resolve op for api func 0x7fcb1c01eb42 for obj=0x400000d89abe (Efl.Ui.Box)

And nothing changes on the screen.

homogeneous checkbox will work with D8219

NOTE: Clicking the Flow checkbox had all kinds of effects, from segfaulting to rebooting my machine.

This issue will fixed by D8217

segfaultxavi accepted this revision.Mar 7 2019, 3:26 AM

Works as expected.

This revision is now accepted and ready to land.Mar 7 2019, 3:28 AM
Closed by commit rEFLf4b69b9c4d85: ui.box,table: update layout when homogeneous mode is changed. (authored by Yeongjong Lee <yj34.lee@samsung.com>, committed by zmike). · Explain WhyMar 8 2019, 5:35 AM
This revision was automatically updated to reflect the committed changes.