Page MenuHomePhabricator

ui.widget: set the parent-child relation again, when the widget is unpacked
Changes PlannedPublic

Authored by YOhoho on Mar 7 2019, 9:27 AM.

Details

Summary

_elm_widget_sub_object_redirect_to_top should be called in unpack functions.

ref D3957

Test Plan

Check this issue.
https://phab.enlightenment.org/D3855
The unset widget don't added any widget as child.
So when it set scale, the widget can not reload the theme.

  1. make check

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10132
Build 8147: arc lint + arc unit
YOhoho created this revision.Mar 7 2019, 9:27 AM
YOhoho requested review of this revision.Mar 7 2019, 9:27 AM
cedric added a comment.Mar 7 2019, 9:32 AM

I feel like we could actually have a test added to elementary that check the result. Would you mind looking at this?

YOhoho updated this revision to Diff 20280.Mar 7 2019, 9:19 PM
YOhoho edited the test plan for this revision. (Show Details)
YOhoho added a reviewer: cedric.

Just add unit test related to this patch

YOhoho updated this revision to Diff 20354.Mar 9 2019, 1:24 AM

remove btn3 that is a duplicate of btn2

YOhoho updated this revision to Diff 20355.Mar 9 2019, 2:03 AM

fix unpack_all of ui.table

YOhoho planned changes to this revision.Mar 10 2019, 8:33 AM

I need to verify redirect_to_top function.

What is the difference between unpack and clear ? It looks to me a bit dangerous that one function unsets the widget parent, the other is not.

What is the difference between unpack and clear ? It looks to me a bit dangerous that one function unsets the widget parent, the other is not.

I'm checking that