Page MenuHomePhabricator

efl: ensure legacy is only relying on stable types
ClosedPublic

Authored by bu5hm4n on Mar 9 2019, 6:02 AM.

Details

Summary

This commit changes the beta ness of a few types, those types are
looking quite stable. Edje types will likely not change. The
Efl.Gfx.Join types are actaully already stable since the last release,
since evas_vg was stable back then and those enums have been in there.

The elementary stuff looks a bit unthought, and we have the chance to
change the API in the backend, so maybe we want to not declare it
stable, but rather reintroduce the legacy types.

With this we can enable eolian generation of beta tags for types.

ref T7726

Depends on D8276

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Mar 9 2019, 6:02 AM
bu5hm4n requested review of this revision.Mar 9 2019, 6:02 AM
segfaultxavi requested changes to this revision.Mar 9 2019, 6:40 AM
segfaultxavi added inline comments.
src/bin/eolian/types.c
159–160

You need to remove this comment too.

This revision now requires changes to proceed.Mar 9 2019, 6:40 AM
bu5hm4n updated this revision to Diff 20377.Mar 9 2019, 6:43 AM
bu5hm4n edited the summary of this revision. (Show Details)

remove dead comment

q66 accepted this revision.Mar 9 2019, 7:05 AM
segfaultxavi accepted this revision.Mar 9 2019, 7:33 AM
This revision is now accepted and ready to land.Mar 9 2019, 7:33 AM
Closed by commit rEFL1c62ed5349b3: efl: ensure legacy is only relying on stable types (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by segfaultxavi). · Explain WhyMar 9 2019, 7:39 AM
This revision was automatically updated to reflect the committed changes.