Page MenuHomePhabricator

elm_entry: fix to return a error code if a argument is not valid
ClosedPublic

Authored by akanad on Wed, Mar 13, 10:43 PM.

Details

Summary

if format is not specified, it should return some error code.
this is a kind of a patch to keep backward compatability of the api.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
akanad created this revision.Wed, Mar 13, 10:43 PM
akanad requested review of this revision.Wed, Mar 13, 10:43 PM
zmike requested changes to this revision.Thu, Mar 14, 8:38 AM
zmike added inline comments.
src/lib/elementary/elm_entry.c
198

I don't think there is any point where this value is used? The point of setting to 0 initially was to improve readability.

This revision now requires changes to proceed.Thu, Mar 14, 8:38 AM
akanad updated this revision to Diff 20601.Thu, Mar 14, 6:32 PM

As you wish.

zmike accepted this revision.Fri, Mar 15, 6:40 AM
This revision is now accepted and ready to land.Fri, Mar 15, 6:40 AM
This revision was automatically updated to reflect the committed changes.