Page MenuHomePhabricator

efl_ui_focus_manager_calc: Fix resource leaks
ClosedPublic

Authored by devilhorns on Thu, Mar 14, 10:14 AM.

Details

Summary

Coverity reports that we leak old_chain & chain variables here if we return.
Add an eina_array_free for both to clean this up.

Fixes Coverity CID1396984,CID1396965

@fix

Depends on D8353

Diff Detail

Repository
rEFL core/efl
Branch
devs/devilhorns/coverity
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 10345
devilhorns created this revision.Thu, Mar 14, 10:14 AM
devilhorns requested review of this revision.Thu, Mar 14, 10:14 AM
cedric requested changes to this revision.Thu, Mar 14, 4:01 PM
cedric added inline comments.
src/lib/elementary/efl_ui_focus_manager_calc.c
1492

Maybe a goto end would actually reduce the code duplication in a better way.

This revision now requires changes to proceed.Thu, Mar 14, 4:01 PM
devilhorns added inline comments.Fri, Mar 15, 5:21 AM
src/lib/elementary/efl_ui_focus_manager_calc.c
1492

Sure, no problem :)

devilhorns marked 2 inline comments as done.Fri, Mar 15, 5:53 AM
devilhorns updated this revision to Diff 20620.Fri, Mar 15, 5:55 AM
devilhorns edited the summary of this revision. (Show Details)

Update patch based on review comments

devilhorns updated this revision to Diff 20626.Fri, Mar 15, 6:02 AM
devilhorns edited the summary of this revision. (Show Details)

no changes

devilhorns updated this revision to Diff 20641.Fri, Mar 15, 9:43 AM

no changes

cedric accepted this revision.Fri, Mar 15, 9:48 AM
This revision is now accepted and ready to land.Fri, Mar 15, 9:48 AM
devilhorns closed this revision.Fri, Mar 15, 9:56 AM