Page MenuHomePhabricator
Differential D8357

eo: refactor auto_unref logic used by efl_part.
ClosedPublic
Actions

Authored by cedric on Mar 14 2019, 2:28 PM.

Details

Reviewers
stefan_schmidt
zmike
bu5hm4n
segfaultxavi
YOhoho
Commits
rEFLadf4512a3520: eo: refactor auto_unref logic used by efl_part.
Summary

This bring no functional change to Eo and efl_part.

Depends on D8336

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Mar 14 2019, 2:28 PM
bu5hm4n requested changes to this revision.Mar 14 2019, 2:33 PM
bu5hm4n added inline comments.
src/lib/eo/eo.c
718

Are you 100000% sure of that change ? why is there no -- initially here ?

This revision now requires changes to proceed.Mar 14 2019, 2:33 PM
cedric added inline comments.Mar 14 2019, 2:47 PM
src/lib/eo/eo.c
718

I do not understand the question. The -- is only on the if below that will trigger efl_unref the right amount of time and there is no change in the behavior with what was done before.

bu5hm4n accepted this revision.Mar 14 2019, 2:50 PM

I simply looked in the wrong line, sorry.

This revision is now accepted and ready to land.Mar 14 2019, 2:50 PM
cedric updated this revision to Diff 20649.Mar 15 2019, 5:00 PM
cedric edited the summary of this revision. (Show Details)
cedric added a reviewer: YOhoho.

Rebase.

cedric updated this revision to Diff 20998.Mar 27 2019, 2:34 PM

Rebase.

Closed by commit rEFLadf4512a3520: eo: refactor auto_unref logic used by efl_part. (authored by cedric). · Explain WhyMar 27 2019, 3:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/lib/eo/eo.c (28 lines)

Diff 21019

View Options

src/lib/eo/eo.c

Loading...