Page MenuHomePhabricator

csharp: Support Efl.Class for interfaces
ClosedPublic

Authored by lauromoura on Mar 14 2019, 3:47 PM.

Details

Summary

The GetEflClassStatic method for interface is in their Concrete
sidekick.

Previously, passing a valid Eo interface as a type caused the binding to
complain that Type is not an Efl.Object.

Test Plan

run test case

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lauromoura created this revision.Mar 14 2019, 3:47 PM
lauromoura requested review of this revision.Mar 14 2019, 3:47 PM
vitor.sousa added inline comments.Mar 15 2019, 6:54 AM
src/bindings/mono/eo_mono/iwrapper.cs
628

Maybe throwing a specific exception here (if objectType == null) would be better than having a null pointer exception in the call bellow it. What do you think?

vitor.sousa added inline comments.Mar 15 2019, 7:07 AM
src/bindings/mono/eo_mono/iwrapper.cs
628

Correcting, I think just returning and IntPtr.Zero would be fine.
Since the type is not required to be and derived from Efl.

lauromoura updated this revision to Diff 20630.Mar 15 2019, 7:21 AM

Rebase and check for null object from the Concrete class.

vitor.sousa accepted this revision.Mar 15 2019, 7:37 AM
This revision is now accepted and ready to land.Mar 15 2019, 7:37 AM
This revision was automatically updated to reflect the committed changes.