Page MenuHomePhabricator

meson: do not set max log level
Needs ReviewPublic

Authored by bu5hm4n on Fri, Mar 15, 6:36 AM.

Details

Summary

Each time we went into release mode, no DBG or INFO output is coming to
the console, this is somewhat annoying, because this means we cannot
continue debugging when we are in the feature freeze, which is actaully
there to do ... debugging and bug hunting. Hence i would like to keep
the max log level here where it is for the other profiles.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 10346
bu5hm4n created this revision.Fri, Mar 15, 6:36 AM
bu5hm4n requested review of this revision.Fri, Mar 15, 6:36 AM

Hum, this patch make me wonder how we can set the max_log_level actually.

bu5hm4n updated this revision to Diff 20642.Fri, Mar 15, 9:53 AM
bu5hm4n edited the summary of this revision. (Show Details)

now a real commit message

@cedric I don't understand, what do you mean ?

The next line are :

if with_max_log_level != -1
   config_h.set('EINA_LOG_LEVEL_MAXIMUM', with_max_log_level)
endif

So I am not sure how we now define with_max_log_level != -1 anywhere in this file.

We just don't define it. The whole feature-freeze time right now means that no dev nor user can get debugging output, and that is IMO super bad, and really annoying if you debug things.