Page MenuHomePhabricator

meson: do not set max log level
AbandonedPublic

Authored by bu5hm4n on Mar 15 2019, 6:36 AM.

Details

Summary

Each time we went into release mode, no DBG or INFO output is coming to
the console, this is somewhat annoying, because this means we cannot
continue debugging when we are in the feature freeze, which is actaully
there to do ... debugging and bug hunting. Hence i would like to keep
the max log level here where it is for the other profiles.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 10346
bu5hm4n created this revision.Mar 15 2019, 6:36 AM
bu5hm4n requested review of this revision.Mar 15 2019, 6:36 AM

Hum, this patch make me wonder how we can set the max_log_level actually.

bu5hm4n updated this revision to Diff 20642.Mar 15 2019, 9:53 AM
bu5hm4n edited the summary of this revision. (Show Details)

now a real commit message

@cedric I don't understand, what do you mean ?

The next line are :

if with_max_log_level != -1
   config_h.set('EINA_LOG_LEVEL_MAXIMUM', with_max_log_level)
endif

So I am not sure how we now define with_max_log_level != -1 anywhere in this file.

We just don't define it. The whole feature-freeze time right now means that no dev nor user can get debugging output, and that is IMO super bad, and really annoying if you debug things.

zmike added a comment.Mar 27 2019, 8:29 AM

I think the point of this was actually for optimization so that lower level messages are immediately discarded instead of being processed in any way?

That is nice, however, having this optimization the whole time while being in a feature freeze is making live very hard...

zmike added a comment.Mar 28 2019, 8:21 AM

I'm not advocating for the behavior, just explaining why it exists.

zmike added a comment.Mar 29 2019, 6:54 AM

I think a better fix for this would be to just not leave release mode enabled for the entire freeze time of a release. When I was doing Enlightenment releases, this would be enabled only for the exact commit that a release was created from, and it also made it much easier to determine exactly which commit was the release version.

bu5hm4n abandoned this revision.EditedApr 20 2019, 6:04 AM

Lets see how we handle the release mode after the autotools removal.