Page MenuHomePhabricator

evas_3d: stop just segfaulting straight away
ClosedPublic

Authored by bu5hm4n on Mar 17 2019, 4:07 AM.

Details

Summary

there have been wrong function calls, that did not work at all, since
the function pointer had the wrong type. This fixes the segfaulting
examples of evas3d. However, they still do not render, at least, they
don't crash anymore.

Depends on D8381

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Mar 17 2019, 4:07 AM
bu5hm4n requested review of this revision.Mar 17 2019, 4:07 AM
zmike requested changes to this revision.Mar 26 2019, 6:23 AM
zmike added inline comments.
src/modules/evas/engines/gl_generic/Evas_Engine_GL_Generic.h
169

This function appears to duplicate the function above it with far less success.

src/modules/evas/engines/gl_generic/evas_engine.c
2309

Use gl_generic_any_output_get.

2320

Same as above (also this was wrong).

This revision now requires changes to proceed.Mar 26 2019, 6:23 AM
bu5hm4n added inline comments.Mar 26 2019, 6:42 AM
src/modules/evas/engines/gl_generic/evas_engine.c
2309

No. eng_context_3d_use requires Render_Output_GL_Generic* not Outbuf*

bu5hm4n updated this revision to Diff 20958.Mar 26 2019, 6:42 AM
bu5hm4n edited the summary of this revision. (Show Details)

update based on review

zmike accepted this revision.Mar 26 2019, 7:09 AM

Seems good.

This revision is now accepted and ready to land.Mar 26 2019, 7:09 AM
Closed by commit rEFL17e60a55851c: evas_3d: stop just segfaulting straight away (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by zmike). · Explain WhyMar 26 2019, 7:10 AM
This revision was automatically updated to reflect the committed changes.