evas_3d: stop just segfaulting straight away
ClosedPublic
Actions

Authored by bu5hm4n on Mar 17 2019, 4:07 AM.

Details

Reviewers

cedric
segfaultxavi
zmike
stefan_schmidt

Commits

rEFL17e60a55851c: evas_3d: stop just segfaulting straight away

Summary

there have been wrong function calls, that did not work at all, since
the function pointer had the wrong type. This fixes the segfaulting
examples of evas3d. However, they still do not render, at least, they
don't crash anymore.

Depends on D8381

Diff Detail

Repository

rEFL core/efl

Branch

master

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 10372

bu5hm4n created this revision.Mar 17 2019, 4:07 AM

Herald added a project: efl. · View Herald TranscriptMar 17 2019, 4:07 AM

Herald added subscribers: committers, reviewers. · View Herald Transcript

bu5hm4n requested review of this revision.Mar 17 2019, 4:07 AM

Harbormaster completed remote builds in B10372: Diff 20668.Mar 17 2019, 4:08 AM

zmike requested changes to this revision.Mar 26 2019, 6:23 AM

zmike added inline comments.

src/modules/evas/engines/gl_generic/Evas_Engine_GL_Generic.h
169	This function appears to duplicate the function above it with far less success.
src/modules/evas/engines/gl_generic/evas_engine.c
2309	Use `gl_generic_any_output_get`.
2320	Same as above (also this was wrong).

This revision now requires changes to proceed.Mar 26 2019, 6:23 AM

bu5hm4n added inline comments.Mar 26 2019, 6:42 AM

src/modules/evas/engines/gl_generic/evas_engine.c
2309	No. eng_context_3d_use requires `Render_Output_GL_Generic` not `Outbuf`

update based on review

Harbormaster completed remote builds in B10571: Diff 20958.Mar 26 2019, 6:42 AM

Seems good.

This revision is now accepted and ready to land.Mar 26 2019, 7:09 AM

Closed by commit rEFL17e60a55851c: evas_3d: stop just segfaulting straight away (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by zmike). · Explain WhyMar 26 2019, 7:10 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
~		src/examples/evas/meson.build (4 lines)
~		src/examples/evas/shooter/evas-3d-shooter-header.h (6 lines)
~		src/examples/evas/shooter/evas-3d-shooter.c (5 lines)
A	M	src/examples/evas/shooter/meson.build (5 lines)
~		src/lib/evas/canvas/evas_canvas3d_node.c (1 line)
~		src/modules/evas/engines/gl_generic/Evas_Engine_GL_Generic.h (15 lines)
~		src/modules/evas/engines/gl_generic/evas_engine.c (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	20668	7b76da0		Mar 17 2019, 4:07 AM	★	★
Diff 2	20958	eae00db	update based on review	Mar 26 2019, 6:41 AM	★	★
Diff 3	20959	2e545ee	rEFL17e60a55851c8d37ccd8cabb5757a9c0f59e2930	Mar 26 2019, 7:09 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
9153d833938f	4eda3fde9747	7b76da0e5d9c	Marcel Hollerbach	(Show More…)	Jan 25 2019, 11:37 AM

Status	Author	Revision
Closed	bu5hm4n	D8382 evas_3d: stop just segfaulting straight away
Abandoned	bu5hm4n	D8381 elm_fileselector_entry: only create model once
Closed	bu5hm4n	D8380 examples_checks: add more configurations to how to run examples
Closed	bu5hm4n	D8379 edje-multisense: add the theme file
Closed	bu5hm4n	D8378 edje-swallow2: differeniate between build dir and source dir
Closed	bu5hm4n	D8377 inwin_example: shot can never be the preferend engine