Page MenuHomePhabricator

efl-mono: Add Remove method to list, arrays and eina_value containers. T7401
Needs RevisionPublic

Authored by felipealmeida on Mar 17 2019, 5:00 PM.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10374
Build 8202: arc lint + arc unit
felipealmeida created this revision.Mar 17 2019, 5:00 PM
felipealmeida requested review of this revision.Mar 17 2019, 5:00 PM

Missing tests? :)

src/bindings/mono/eina_mono/eina_array.cs
126

Shouldn't this be RemoveAt like Eina.Array and Eina.Value?

129

Shouldn't this be under a if (OwnContent) check?

src/bindings/mono/eina_mono/eina_list.cs
232

Missing checking the actual index? This would always lead to curr == IntPtr.Zero.

237

Check if (OwnContent)?

lauromoura requested changes to this revision.Mar 18 2019, 6:36 AM
This revision now requires changes to proceed.Mar 18 2019, 6:36 AM