Page MenuHomePhabricator

efl_access_text_selections_count_get implementation for Entry
AbandonedPublic

Authored by ali.alzyod on Mar 18 2019, 9:56 AM.

Details

Summary

correct implementation for "efl_access_text_selections_count_get" to return count instead of 0 or 1.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10391
Build 8212: arc lint + arc unit
ali.alzyod created this revision.Mar 18 2019, 9:56 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Mar 18 2019, 9:56 AM
ali.alzyod retitled this revision from Fix _entry_has_new_line on detecting new lines when it finds <br> <ps> in passed string to efl_access_text_selections_count_get implementation for Entry.Mar 18 2019, 10:04 AM
This comment was removed by ali.alzyod.
bu5hm4n requested changes to this revision.Mar 19 2019, 11:01 AM
bu5hm4n added a subscriber: bu5hm4n.

This seems wrong considering the documentation of atspi. According to [1] the idea of this API is that this returns the number of *contiguous* selections in the current text object. Considering this, this patch looks wrong.

[1]: https://people.gnome.org/~billh/at-spi-idl/html/interfaceAccessibility_1_1Text.html#a11

This revision now requires changes to proceed.Mar 19 2019, 11:01 AM
ali.alzyod abandoned this revision.Mar 20 2019, 2:19 AM

this function return count of selection regions, not the length of selected string